ctags icon indicating copy to clipboard operation
ctags copied to clipboard

Pascal: Parse first `type` identifier

Open ntrel opened this issue 4 years ago • 7 comments

This is a change ported from Geany. ~~Needs tests.~~

ntrel avatar Oct 16 '19 16:10 ntrel

Coverage Status

Coverage increased (+0.008%) to 86.311% when pulling ea47066a4694860e0366b92d65f4a9a904e51ec5 on ntrel:pas-type into 1da465977aea76cc3986a9fcebf9615e08ea811c on universal-ctags:master.

coveralls avatar Oct 22 '19 14:10 coveralls

Test cases under review-needed.r were imported from exuberant-ctags. As the directory name shows, we don't understand what kind of tags output is expected for the input.

If you know Pascal, I would like you to review the test case first. If you don't want to review, introduce a new test case for your change instead of extending review-needed.r/bug612019.pas.t.

masatake avatar Oct 22 '19 15:10 masatake

I would like you to review the test case first

Test case looks fine.

introduce a new test case for your change instead of extending review-needed.r/bug612019.pas.t

This pull will modify the tags generated by the existing test case. All I did was add a function.

ntrel avatar Oct 22 '19 15:10 ntrel

Test case looks fine. Thank you.

This pull will modify the tags generated by the existing test case. All I did was add a function.

Your work is nothing to do with bug612019.pas, isn't it? The name of the test case points a bug report at Exuberant-ctags project run at Sourceforge.

masatake avatar Oct 22 '19 15:10 masatake

Test case looks fine

Although the procedures and function (which I added) should maybe have an empty parameter list.

ntrel avatar Oct 22 '19 15:10 ntrel

Your work is nothing to do with bug612019.pas, isn't it?

It has a type declaration.

ntrel avatar Oct 22 '19 15:10 ntrel

It has a type declaration.

Do you mean the original test input has a type declaration, and so you reuse the test input for your work?

masatake avatar Oct 22 '19 15:10 masatake