darts icon indicating copy to clipboard operation
darts copied to clipboard

Fix 2 tuple type annotations in TimeSeries

Open ajyoon opened this issue 9 months ago • 1 comments

Checklist before merging this PR:

  • [ ] ~~Mentioned all issues that this PR fixes or addresses.~~ (N/A)
  • [x] Summarized the updates of this PR under Summary.
  • [ ] Added an entry under Unreleased in the Changelog.

Summary

  • TimeSeries.shape was incorrectly annotated tuple[int]; this is changed to tuple[int, int, int].
  • The quantiles argument in TimeSeries.quantiles_df was incorrectly annotated tuple[float]; this is changed to tuple[float, ...].

ajyoon avatar May 28 '25 18:05 ajyoon

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.18%. Comparing base (b71851b) to head (5324c4e). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2812      +/-   ##
==========================================
- Coverage   95.26%   95.18%   -0.08%     
==========================================
  Files         145      145              
  Lines       15126    15126              
==========================================
- Hits        14410    14398      -12     
- Misses        716      728      +12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 02 '25 07:06 codecov[bot]

@dennisbader apologies for my delay - looks like you beat me on the quantiles change, so I've merged upstream and removed those changes. This PR is now just the annotation fix on TimeSeries.shape

ajyoon avatar Jun 24 '25 19:06 ajyoon