darts
darts copied to clipboard
Change create_lagged_data and regressionmodel in order to have the names of the features by default in the sklearn model
I had a look on how it could be implemented ; the training_samples
array in _fit_model()
can be converted into a pd.DataFrame
(or similar data structure) with the values generated by create_lagged_component_names()
as columns. A similar approach must be used in predict()
to avoid the warnings generated by sklearn when the features array passed to model.predict()
do not have columns names.
I don't find this approach elegant, and not sure if the benefits are worth the trouble. WDYT @dennisbader?
If converting to a pd.DataFrame then I'd rather avoid it (thinking about computational cost).
I mean, xarray.DataArray
could also be used since it also allow for labeled dimensions without adding too much computational overhead?
Should I run a quick benchmark to assess the impact on the performance?