unison icon indicating copy to clipboard operation
unison copied to clipboard

codebase UI shows wrong docs for a hash qualified name in a relative view

Open iamevn opened this issue 3 years ago • 3 comments

Here is a term on unison share in the namespace containing that term queried by name and queried by hash. The hash query shows docs from another term with a similar name. this term should have no docs.

They both query /api/getDefinition with the same parameters for rootBranch and relativeTo but differ for names (hashes shortened):

names=main
rootBranch=#rubverph...
relativeTo=iamevn.advent.year2021.day03

names=%2369dn0q...
rootBranch=#rubverph...
relativeTo=iamevn.advent.year2021.day03

The response for the hash query includes entries in termDocs where there should be none: image

Going from the root namespace instead seems to work correctly: query by name / query by hash

iamevn avatar Dec 13 '21 07:12 iamevn

Hmmm, thought this one had been fixed (https://github.com/unisonweb/unison/issues/2557). Should verify if this problem is just the server or if ucm is impacted as well.

hojberg avatar Dec 13 '21 15:12 hojberg

@ceedubs reports this also happening on the new Share.

hojberg avatar Aug 01 '22 21:08 hojberg

@aryairani I might need some backend assistance on this.

hojberg avatar Aug 01 '22 21:08 hojberg

Here's an example

CleanShot 2022-08-10 at 08 45 50@2x

https://share.unison-lang.org/@hojberg/code/latest/namespaces/public/projects/html/latest/;/terms/div

hojberg avatar Aug 10 '22 12:08 hojberg