unison icon indicating copy to clipboard operation
unison copied to clipboard

Verify that kinds are the same when propagating type edits

Open pchiusano opened this issue 3 years ago • 2 comments

Right now when you add a type replacement to a patch, during propagation, we don't verify that the kinds of the old and new type are the same. This can lead to ill-kinded type declarations and then terms that depend on those ill-kinded declarations can't typecheck (or maybe they can still typecheck, but they can't actually be called).

Anyway, I thought we were being overly conservative previously and refusing to do any type propagation, but it turns out we just had bug in the constructor mapping: #2254

pchiusano avatar Jul 09 '21 18:07 pchiusano

Idea to increase certainty of this: reduce scope of the issue to a timeboxed investigation of possible fix

pchiusano avatar Jul 12 '21 17:07 pchiusano

Depends on #567

runarorama avatar Jul 13 '21 17:07 runarorama