Contribution “changes” don’t match the actual edits

[sellout]

TODO: At the time of writing, the “Changes” view on Share isn’t rendering the diffs, so there is context missing here. Once the diff is repaired, I need to review and correct this report. (Then delete this TODO.)

I made a contribution to a project, but the changes displayed don’t match the changes I made.

The changes I made are to

• add a bunch of terms under postgres.Postgres.internal.startup.authenticationSASL and
• modify postgres.Postgres.internal.startupExchange to use the new terms.

Beyond that, I would expect to see a bunch of modifications of the transitive dependents of startupExchange, since the hash changed.

However, it also shows a number of new terms added in other places in the project, which already exist on the target branch.

[hojberg]

There's been a lot of changes to the diff output in the last few weeks. One notable thing is that we now hide propagated changes to reduce the noise.

Does this still include unexpected terms?

[hojberg]

@sellout this might look different when your contribution is merged, but I think there's a chance with all the backend changes we made in the diff area that this is fixed.

[sellout]

Yeah, I’m going to close this. The contribution has been merged, and I don’t know why that particular one seemed off. If I come across something like this again, I’ll try to have a good reproduction to share.