hoc-react-loader icon indicating copy to clipboard operation
hoc-react-loader copied to clipboard

Improve contrast in TailSpin component

Open frinyvonnick opened this issue 8 years ago • 3 comments

frinyvonnick avatar Nov 02 '17 08:11 frinyvonnick

@fabienjuif it seems to work accordingly to this test. But on dark colors like black contrast is a bit light.

frinyvonnick avatar Nov 02 '17 13:11 frinyvonnick

We should detect if the retrieve background color is more light than dark, and then apply the appropriate color transformation from this.

fabienjuif avatar Nov 03 '17 08:11 fabienjuif

I suggested to use getBrightness from tinycolor

frinyvonnick avatar Nov 07 '17 14:11 frinyvonnick