Homa Wong

Results 275 comments of Homa Wong

It's the strict-peer deps issue. `npm@8`, `yarn@3`, `pnpm` are moving to that model. So make need to update the deps soon.

Strict-peer deps is for the better in general. The NPM peer dependency resolution was broken to begin with, so the tools finally trying to right the boat.

> Just for the record, no, we are not. Good to know. I thought it was doing similar thing as pnpm. thx for the clarification. 🌷

I can do that. Do you mind I add `typescript` as a devDeps so I can add a few tests?

This is a huge issue as it causes VSCode to completely hang during folder find/replace. You can change dozen - hundreds of files at once. `vs-deploy` seems to create one...

When looking deeper into the error, it is caused by this: `command 'extension.deploy.file' not found` Can confirm downgrading to 1.52.1 fixes it.

Can the implementation in https://github.com/eligrey/Blob.js be used in `jsdom`? I'm blocked by this for using `jspdf` inside `jsdom`.

I'm not familiar with this, will it be something like this? ```js createObjectURL(blob) { var implementationDefinedValue = ??? var url = `blob:${asciiSerialize(location.origin) || implementationDefinedValue}/${createUUID()}`; saveToBlobStore(url, blob); return url; } revokeObjectURL(blobUrl)...

That means: ```js const uuid = require('uuid/v4'); createObjectURL(blob) { var implementationDefinedValue = ??? var url = `blob:${asciiSerialize(location.origin) || implementationDefinedValue}/${uuid()}`; return url; } revokeObjectURL(blobUrl) { return; } asciiSerialize(origin) { if (origin.scheme)...

Seems like I get all the questions answered. http://stackoverflow.com/questions/42452543/what-does-implementation-defined-value-in-fileapi-unicodebloburl-mean/42452714#42452714 I think it is ready to be implemented at https://github.com/jsdom/whatwg-url UPDATE: Turns out `whatwg-url` has most things available. So I guess...