Homa Wong

Results 460 comments of Homa Wong

It should add that depends on what you currently have. Will check.

I looked at it and I think it really depends on your setup. For example, you may be using `editorconfig` with is set to remove that line, or using prettier...

At the same time, [this line](https://github.com/unional/vscode-sort-package-json/blob/main/src/sortPackageJson.ts#L20) supposed to preserve the existing format.

um... IMO the design shouldn't be constraint due the the needs on development. The `slot` prop is here and it is awkward that for some slots provided by RAC the...

Thanks for your explanation. I can understand your reasoning. I think the problems comes down to Dependency Inversion. That the slot mechanism depends on a "fixed" list of permitted slots...

Thanks. I notice this issue as Steve upgrade `@storybook-community/storybook-dark-mode` to support v10. I assume that it is a new way to define the preview not necessarily exclusively for CSF Next....

One more thing, since new addon using `definePreviewAddon` and it should be registered in `definePreview({ addons: [] })`, does it mean that addons upgraded to support will not support CSF...

> That means this issue would require users to also maintain two preview files. I confirmed that this is a problem. CSF Next `preview.ts` does not work correctly with CSF...

Example for all 4 corners: ![image](https://github.com/adobe/react-spectrum/assets/3254987/08132277-93c8-4f3d-9bca-cd182c1085d6) Note that related to #6505, I have `isOpen` but it is not rendered in this case because the positions are off screen.