Homa Wong

Results 372 comments of Homa Wong

One of the inconsistency is that some of the common functions such as `render()` is returning `void` or `Promise` depends on which prompt we can working with. My guess is...

As I'm doing this, I'm also adding more tests to cover all use cases. At the end of the exercise, the cover coverage should be very close to 100%.

Hi @doowb, no problem. :) The DT approach wouldn't work because the library already expose its type. If someone creates and uses `@types/enquirer` now, it will result in conflict. So...

Not a problem~. I convert the test from JavaScript to TypeScript because I can "eat my own dog food" as working on the type definition. When everything is said and...

@jpike88 100% agree to what you said about `@types`. But in general it is the same when the typings are defined but not align to the code within the project....

Some of the code such as `state` and `symbols` are not typed because I'm not sure should they be exposed.

Sure, no problem. Take your time. I would expect some more changes are needed because I just follow the tests and readme for `prompt()` function.

For the failed tests, I'll take a look at them this week. Seems like some problems with Node 10 and 11.

The last error seems like a random error. Can you take a look?

> I'm not sure about the error. Seems like the test `should works in child_process` is failing: I don't know either. I have run the test locally using NodeJS 8...