react-styleguidist-visual icon indicating copy to clipboard operation
react-styleguidist-visual copied to clipboard

Clean up after successful test run

Open kot-lex opened this issue 7 years ago • 3 comments
trafficstars

Wouldn't it be more useful if we will delete .new.png and .diff.png for the successful tests? Current approach requires running approve command every time even if all screenshots match the reference ones.

kot-lex avatar Jun 11 '18 10:06 kot-lex

if all screenshots match the reference ones

Why do you need to approve if they're the same?

unindented avatar Jun 11 '18 15:06 unindented

Just to prevent them from being accidentally committed into repo. Another solution is to add *.diff.png and *.new.png into .gitignore, but what is the use of those files in case tests were passed?

kot-lex avatar Jun 11 '18 16:06 kot-lex

Ah, we do have those files in our .gitignore, that's probably why this was a non-issue for us.

I'm open to merging a PR that removes those files after successful run though.

unindented avatar Jun 11 '18 17:06 unindented