react-native-unimodules icon indicating copy to clipboard operation
react-native-unimodules copied to clipboard

Investigate alternatives to having users include all permission usage description keys

Open brentvatne opened this issue 5 years ago • 8 comments

Thread: https://www.reddit.com/r/reactnative/comments/avwr6w/you_can_now_use_expo_apis_in_any_react_native_app/ehielm1

brentvatne avatar Mar 01 '19 02:03 brentvatne

React native permissions just released their 2.0 branch where you're not required to add all permissions at once: https://github.com/yonahforst/react-native-permissions/tree/2.0.0 looks like they going with the subspecs route.

pontusab avatar Mar 12 '19 09:03 pontusab

interesting, thanks for pointing that out @pontusab!

brentvatne avatar Mar 14 '19 03:03 brentvatne

Any chance this will land in the near futures. Anyway to help?

MrLoh avatar Oct 15 '19 17:10 MrLoh

@MrLoh - it's very close, see https://github.com/expo/expo/pull/5061

brentvatne avatar Oct 26 '19 19:10 brentvatne

@brentvatne so I saw that https://github.com/expo/expo/pull/5061 landed a while ago but does this resolve this issue. The Readme here still states that all permissions are required.

MrLoh avatar Dec 11 '19 17:12 MrLoh

it did land a while ago but we only just released it. we need to update README accordingly now :)

brentvatne avatar Dec 12 '19 20:12 brentvatne

I was able to get unimodules running as basis for touch/face-id support and came across the same question discussed here. There is a PR waiting but so far it only removes the related sections in the README. Does this mean that I only need to include the specific permissions needed/used?

toytonic avatar Feb 11 '20 03:02 toytonic

Yes

MrLoh avatar Feb 11 '20 05:02 MrLoh