kraftkit icon indicating copy to clipboard operation
kraftkit copied to clipboard

feat(workflows): Enable code spellchecking

Open craciunoiuc opened this issue 1 year ago • 3 comments

Prerequisite checklist

  • [x] Read the contribution guidelines regarding submitting new changes to the project;
  • [x] Tested your changes against relevant architectures and platforms;
  • [x] Ran make fmt on your commit series before opening this PR;
  • [ ] Updated relevant documentation.

Description of changes

This one is for you @nderjung

If we want this to work properly we need to add some custom dictionaries to make sure that words like unikraft and kraftkit, etc. are caught

We can add single exceptions, but I think it warrants a dictionary. Examples: https://github.com/check-spelling/check-spelling/wiki/Feature:-Area-dictionaries

We should not merge until then

craciunoiuc avatar Oct 27 '23 12:10 craciunoiuc

Thanks 😇 But is this not already enabled via golangci-lint ?

nderjung avatar Oct 27 '23 12:10 nderjung

I think that is for variables only? Comments are for sure ommited.

Anyways, this is just an idea right now, they don't really say how this should be structured so I just tried some things

craciunoiuc avatar Oct 27 '23 12:10 craciunoiuc

Converting to draft cause it doesn't really work, also is not that urgent

craciunoiuc avatar Dec 19 '23 10:12 craciunoiuc