kraftkit icon indicating copy to clipboard operation
kraftkit copied to clipboard

fix(manifest): Better handling of Git and GitHub artifacts

Open nderjung opened this issue 1 year ago • 3 comments

Prerequisite checklist

  • [x] Read the contribution guidelines regarding submitting new changes to the project;
  • [x] Tested your changes against relevant architectures and platforms;
  • [x] Ran make fmt on your commit series before opening this PR;
  • [ ] Updated relevant documentation.

Description of changes

This PR makes necessary adjustments to the manifest package to better accommodate for users who wish to specify the Git SHA hash as the version attribute of a component. To make this adjustment a number of changes were necessary:

  • Propagating the Catalog's query of a version to each provider;
  • Allowing a quick-lookup of SHA on GitHub as an archive if --use-git is not provided;
  • Changing the "git checkout" mechanism to facilitate finding the hash amongst different branches.

nderjung avatar Jun 20 '23 13:06 nderjung

Still does not work with GitHub artifacts over ssh :(

craciunoiuc avatar Jun 26 '23 09:06 craciunoiuc

@nderjung I think this is the reason why you remember git SHAs working. Can you rebase this and we try it on staging?

craciunoiuc avatar Dec 19 '23 10:12 craciunoiuc

happy birthday #528

@nderjung rebase? :pleading_face:

craciunoiuc avatar Jun 24 '24 09:06 craciunoiuc