unifios-utilities icon indicating copy to clipboard operation
unifios-utilities copied to clipboard

05-containers-common.sh acts on libpod.conf. libpod.conf was deprecated as of podman 3.0

Open splerman opened this issue 3 years ago • 1 comments

Describe the bug 05-containers-common.sh errors with sed: can't read /etc/containers/libpod.conf: No such file or directory

To Reproduce Steps to reproduce the behavior:

  1. Copy 05-containers-common.sh into /mnt/data/on_boot.d
  2. chmod +x 05-containers-common.sh
  3. . 05-containers-common.sh
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

UDM Information

  • Variant UDM-SE
  • Firmware Version: 2.3.14
  • Controller Version 7.0.22

Additional context Per Podman API v1.0 and libpod.conf Removal Notice, libpod.conf was deprecated and was removed as of Podman 3.0. The functionality was combined into containers.conf. My containers.conf already has log_size_max=104857600. Suggest the script include a check for podman version and checks containers.conf instead of libpod.conf if podman version >= 3.0. I'm still a newbie and don't trust myself, otherwise, I'd set myself up to be able to make a pull-request. For now, I'm fumbling along ever since ditching my Cloudkey 1.0 and USG-4 for a UDM-SE.

splerman avatar Feb 23 '22 20:02 splerman

This seems to check out. Changing the script to point to the /etc/containers/containers.conf should get it.

sithtoast avatar Jun 12 '22 03:06 sithtoast