unicorn AVR support

Hi, this adds support for AVR (#939), while keeping XMEGA bits (with DES instruction) currently separate. This PR is rebased against the current dev branch, while original support was developed and more thoroughly tested against unicorn 2.0.x.

Oct 02 '24 13:10 glennsec

Thanks for the contribution!

please update README to add this new architecture.
please add your name to CREDITS.TXT.

Oct 03 '24 01:10 aquynh

can you look at the issues of the CI?

Oct 03 '24 01:10 aquynh

You need to add Rust bindings manually😅

Oct 03 '24 13:10 bet4it

Thanks for the contribution!

please update README to add this new architecture.

please add your name to CREDITS.TXT.

done

Oct 09 '24 21:10 glennsec

can you look at the issues of the CI?

Fixed all of those except arm64 & ppc64 failures. The arm64 bits may be fixed by #1935 ?

Oct 09 '24 21:10 glennsec

can you look at the issues of the CI?

Fixed all of those except arm64 & ppc64 failures. The arm64 bits may be fixed by #1935 ?

There are also macos failures.

Oct 10 '24 11:10 wtdcode

can you look at the issues of the CI?

Fixed all of those except arm64 & ppc64 failures. The arm64 bits may be fixed by #1935 ?

There are also macos failures.

Hi, this is related to the tcg/aarch64 backend issue mentioned in #1908 with proposed fix in #1935. I have another patch suggestion that fixes the issue, as you can see in the last CI run at https://github.com/glennsec/unicorn/actions/runs/11298077207 (still, ppc64 needs similar treatment).

Oct 11 '24 19:10 glennsec

See #2028. Feel free to integrate whichever (vs. #1935) suits you best. Thanks.

Oct 11 '24 19:10 glennsec

See #2028. Feel free to integrate whichever (vs. #1935) suits you best. Thanks.

@wtdcode : I have updated the branch against #1935 (which applies on top of current dev branch) to include aarch64 & ppc64 fixes. Thanks.

Oct 22 '24 13:10 glennsec

See #2028. Feel free to integrate whichever (vs. #1935) suits you best. Thanks.

@wtdcode : I have updated the branch against #1935 (which applies on top of current dev branch) to include aarch64 & ppc64 fixes. Thanks.

I will have a check this week.

Oct 22 '24 13:10 wtdcode

I'm looking forward for this PR, as my idaemu fork will be redesigned soon, and I wish to add AVR as well.

@aquynh @wtdcode what's have to be done for merge?

Nov 11 '24 09:11 in7egral

I'm looking forward for this PR, as my idaemu fork will be redesigned soon, and I wish to add AVR as well.

@aquynh @wtdcode what's have to be done for merge?

Thanks for reaching out. Unfortunately I'm getting sick recently. Please allow me a few days before coming back.

Nov 11 '24 13:11 wtdcode

Hi @wtdcode, I have fixed the new test failures wrt. the current dev branch. All tests now pass. Do you see anything left you would like me to change prior to committing the patchset to the dev branch? Thanks.

Jan 17 '25 19:01 glennsec

Hi @wtdcode, I have fixed the new test failures wrt. the current dev branch. All tests now pass. Do you see anything left you would like me to change prior to committing the patchset to the dev branch? Thanks.

Thanks for updates. This PR will go to 2.2.0 as mentioned in #2071 as I hope 2.1.2 to be released firstly to address a few urgent issues. I'm sorry for the delay as I'm busy with my academic matters.

Regarding the PR itself, I once quickly reviewed the code and I didn't see obvious flaws or request changes. The quality of integration is rather high and professional. I will take another look once 2.1.2 is out, which should happen shortly.

Jan 18 '25 03:01 wtdcode