unicodetools icon indicating copy to clipboard operation
unicodetools copied to clipboard

Never use ICU properties

Open eggrobin opened this issue 11 months ago • 1 comments

See #1072.

CollatorEquivalencesNew and GenerateNormalizeForMatch both have this:

    static UnicodeSet.XSymbolTable NO_PROPS =
            new UnicodeSet.XSymbolTable() {
                @Override
                public boolean applyPropertyAlias(
                        String propertyName, String propertyValue, UnicodeSet result) {
                    throw new IllegalArgumentException(
                            "Don't use any ICU Unicode Properties! "
                                    + propertyName
                                    + "="
                                    + propertyValue);
                }
                ;
            };

    static {
        UnicodeSet.setDefaultXSymbolTable(NO_PROPS);
    }

We should have something equivalent to that everywhere.

eggrobin avatar Mar 24 '25 14:03 eggrobin

+1

On Mon, Mar 24, 2025 at 7:55 AM Robin Leroy @.***> wrote:

See #1072 https://github.com/unicode-org/unicodetools/issues/1072.

CollatorEquivalencesNew and GenerateNormalizeForMatch both have this:

static UnicodeSet.XSymbolTable NO_PROPS =
        new UnicodeSet.XSymbolTable() {
            @Override
            public boolean applyPropertyAlias(
                    String propertyName, String propertyValue, UnicodeSet result) {
                throw new IllegalArgumentException(
                        "Don't use any ICU Unicode Properties! "
                                + propertyName
                                + "="
                                + propertyValue);
            }
            ;
        };

static {
    UnicodeSet.setDefaultXSymbolTable(NO_PROPS);
}

We should have something equivalent to that everywhere.

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/unicodetools/issues/1074, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMBQ6ZKEIR4OKLNB4P32WAMGXAVCNFSM6AAAAABZVEMTNGVHI2DSMVQWIX3LMV43ASLTON2WKOZSHE2DGNJTGAZDQMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***> [image: eggrobin]eggrobin created an issue (unicode-org/unicodetools#1074) https://github.com/unicode-org/unicodetools/issues/1074

See #1072 https://github.com/unicode-org/unicodetools/issues/1072.

CollatorEquivalencesNew and GenerateNormalizeForMatch both have this:

static UnicodeSet.XSymbolTable NO_PROPS =
        new UnicodeSet.XSymbolTable() {
            @Override
            public boolean applyPropertyAlias(
                    String propertyName, String propertyValue, UnicodeSet result) {
                throw new IllegalArgumentException(
                        "Don't use any ICU Unicode Properties! "
                                + propertyName
                                + "="
                                + propertyValue);
            }
            ;
        };

static {
    UnicodeSet.setDefaultXSymbolTable(NO_PROPS);
}

We should have something equivalent to that everywhere.

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/unicodetools/issues/1074, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMBQ6ZKEIR4OKLNB4P32WAMGXAVCNFSM6AAAAABZVEMTNGVHI2DSMVQWIX3LMV43ASLTON2WKOZSHE2DGNJTGAZDQMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

macchiati avatar Mar 24 '25 15:03 macchiati