icu4x icon indicating copy to clipboard operation
icu4x copied to clipboard

Dense zero trie Out of Range handling #7303

Open Cdog1526 opened this issue 3 weeks ago • 1 comments

Working on https://github.com/unicode-org/icu4x/issues/7303.

When creating a dense sparse zerotrie, if the incoming values are too spread out for a dense matrix:

  • Select the row offset that gets the greatest number of values into the dense matrix.
  • Put all out-of-range values into the primary trie, as we do with sparse rows.

Also, added a test case for this. I am not certain that this test case is sufficient, this is my first contribution here.

Cdog1526 avatar Dec 11 '25 07:12 Cdog1526

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 11 '25 07:12 CLAassistant

@sffc I see that two tests are failing right now, but I'm not really sure how to recreate that on my side - is there something I can run or look at or is this related to me? And is there anything else I should do?

Cdog1526 avatar Dec 21 '25 09:12 Cdog1526

The branch might be stale. I updated it to main

sffc avatar Dec 21 '25 19:12 sffc

Ah awesome, thanks! Let me know if you need anything else to review.

Cdog1526 avatar Dec 22 '25 06:12 Cdog1526