icu4x icon indicating copy to clipboard operation
icu4x copied to clipboard

Add Dart PR health workflow

Open mosuem opened this issue 4 months ago • 6 comments

Add workflow for PR health, checking things like breaking changes, missing exports etc.

mosuem avatar Aug 05 '25 15:08 mosuem

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments or fill out our survey to provide feedback.

gemini-code-assist[bot] avatar Aug 05 '25 15:08 gemini-code-assist[bot]

This adds 8 minutes of runner time to each PR, as well as 7 new jobs to the UI. As we barely touch the Dart package, I don't think this is worth the cost.

robertbastian avatar Sep 26 '25 11:09 robertbastian

Then it should be guarded with a paths filter. I would still recommend adding the workflow, as we don't want to accidentally push breaking changes, especially with tying the versioning of the Dart package to versions of other packages.

mosuem avatar Sep 29 '25 09:09 mosuem

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 29 '25 09:09 CLAassistant

We already have a CI job that detect breaking changes in our FFI layer, which this would just duplicate.

robertbastian avatar Sep 29 '25 09:09 robertbastian

What are the next steps here? Perhaps @robertbastian and @mosuem need to discuss potential paths forward?

We could include this in cronjob CI, perhaps? Not sure if that makes sense for PR health stuff.

Manishearth avatar Oct 29 '25 22:10 Manishearth