icu4x
icu4x copied to clipboard
unicode-org
Document considerations related to lowering the collation strength from the default
Inspired by discovering how Firefox and Thunderbird UI code uses collation and pondering whether it makes sense.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments to provide feedback.
![gemini-code-assist[bot] avatar](https://avatars.githubusercontent.com/in/956858?v=4 "Published by a pub.dev verified publisher"){kind=small}
- @hsivonen (missed)
- @sffc henri i had a couple comments on your PR, will post.
- @hsivonen If you want better performance you shouldn't lower the strength won't get that much better perf. but you'll have user visible weirdness
- @hsivonen but if you have a larger struct with a string field and want to sort on the string field ignoring case and accents then you have multiple ?? equals at that leevel. you can break the tie with the accents, then that's fine.
- @sffc yeah we should state concisely when this isn't the tool for the job just for perf.
