icu4x icon indicating copy to clipboard operation
icu4x copied to clipboard
verified publisher icon unicode-org

Update twoxhash to 2.0

Open Manishearth opened this issue 1 year ago • 2 comments

Supersedes https://github.com/unicode-org/icu4x/pull/5706

Manishearth avatar Oct 18 '24 19:10 Manishearth

Not currently compatible with the repo MSRV.

sffc avatar Oct 18 '24 19:10 sffc

Yep, I plan to leave this PR open for now

Manishearth avatar Oct 18 '24 19:10 Manishearth

1.81 MSRV is far away, can we not keep draft PRs cluttering the repo for extended periods of time?

robertbastian avatar Oct 21 '24 23:10 robertbastian

I think it's fine. We have old draft PRs.

sffc avatar Oct 21 '24 23:10 sffc

And we should clean them up. Most are more work to rebase than to do again, many are not even compatible with current designs anymore.

robertbastian avatar Oct 21 '24 23:10 robertbastian

@Manishearth we are now at 1.81 MSRV

robertbastian avatar Feb 24 '25 12:02 robertbastian

Good catch, thanks!

Manishearth avatar Feb 24 '25 18:02 Manishearth