icu4x icon indicating copy to clipboard operation
icu4x copied to clipboard

Consider renaming resolve_components to resolved_components

Open hsivonen opened this issue 2 years ago • 5 comments

The documentation says it returns what was resolved, but the name suggests triggering resolution.

hsivonen avatar Sep 14 '23 16:09 hsivonen

This is referring to the experimental DateTimeFormatter API.

A bunch of this will probably change under skeletons anyway.

@zbraniecki to approve.

Manishearth avatar Sep 21 '23 17:09 Manishearth

Also, per discussion elsewhere, the return type should probably be some kind of ResolvedBag that doesn't wrap each field in Option.

hsivonen avatar Sep 22 '23 08:09 hsivonen

Agree. And agree with the last comment, the ResolvedBag will come from icu_preferences.

zbraniecki avatar Mar 14 '24 16:03 zbraniecki

This API will be changing in 2.0 but I'll make sure to call it resolved_options.

sffc avatar Jul 24 '24 16:07 sffc

Datetime has a new API for this, which is documented. Might still need to look at other components

sffc avatar Sep 17 '24 18:09 sffc