icu4x
icu4x copied to clipboard
Document inline clippy lints for datetime and plurals
Fixes #1668.
Notice: the branch changed across the force-push!
- components/datetime/src/skeleton/helpers.rs is different
~ Your Friendly Jira-GitHub PR Checker Bot
There's one comment thread that is unresolved. Other than that, this LGTM given the two new issues you filed.
Notice: the branch changed across the force-push!
- components/datetime/src/pattern/runtime/plural.rs is different
- components/datetime/src/skeleton/helpers.rs is different
- components/plurals/src/rules/reference/parser.rs is now changed in the branch
- components/plurals/src/rules/runtime/ast.rs is different
~ Your Friendly Jira-GitHub PR Checker Bot
I made the conversion from reference AST to runtime AST fallible.
Codecov Report
Merging #2572 (9b6c54e) into main (3d80f0d) will decrease coverage by
0.65%
. The diff coverage is84.00%
.
@@ Coverage Diff @@
## main #2572 +/- ##
==========================================
- Coverage 73.99% 73.34% -0.66%
==========================================
Files 420 427 +7
Lines 35041 36726 +1685
==========================================
+ Hits 25930 26935 +1005
- Misses 9111 9791 +680
Impacted Files | Coverage Δ | |
---|---|---|
...omponents/datetime/src/pattern/reference/parser.rs | 97.28% <0.00%> (ø) |
|
components/datetime/src/pattern/runtime/plural.rs | 89.61% <ø> (-0.59%) |
:arrow_down: |
components/plurals/src/rules/reference/lexer.rs | 93.47% <ø> (ø) |
|
components/plurals/src/rules/reference/parser.rs | 95.56% <ø> (ø) |
|
components/datetime/src/skeleton/helpers.rs | 90.35% <66.66%> (-1.32%) |
:arrow_down: |
components/plurals/src/rules/runtime/ast.rs | 85.71% <95.00%> (-0.26%) |
:arrow_down: |
components/datetime/src/format/zoned_datetime.rs | 75.55% <0.00%> (-13.34%) |
:arrow_down: |
components/collections/src/codepointtrie/serde.rs | 80.00% <0.00%> (-4.22%) |
:arrow_down: |
components/plurals/src/operands.rs | 79.51% <0.00%> (-4.02%) |
:arrow_down: |
...r/datagen/src/transform/cldr/datetime/skeletons.rs | 90.90% <0.00%> (-2.85%) |
:arrow_down: |
... and 88 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@zbraniecki you need to mark the CLA as signed (iirc Amazon falls under the Unicode CLA so you just have to tell the tool)
cc @srl295 just in case
merging with admin in the meantime