icu4x icon indicating copy to clipboard operation
icu4x copied to clipboard

Published 20 hours ago • verified publisher icon unicode-org

icu_segmenter denies the clippy::indexing_slicing.

Open makotokato opened this issue 2 years ago • 1 comments

Adding deny(clippy::indexing_slicing) to icu_segmenter.

makotokato avatar Aug 03 '22 09:08 makotokato

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 01 '22 06:09 CLAassistant

I think @aethanyc's recent PR fixes this; can you confirm, and close this PR if needed?

sffc avatar Nov 10 '22 18:11 sffc

I think @aethanyc's recent PR fixes this; can you confirm, and close this PR if needed?

I believe we still needs this PR. I didn't enable clippy::indexing_slicing in my recent work.

https://github.com/unicode-org/icu4x/blob/46aad80e015dd1df5eb0828c9842fb9276c93cbd/experimental/segmenter/src/lib.rs#L77-L82

aethanyc avatar Nov 12 '22 03:11 aethanyc

Cool; @makotokato can you update your branch with the latest changes from main and address the other feedback from above?

sffc avatar Nov 14 '22 16:11 sffc

Notice: the branch changed across the force-push!

  • experimental/segmenter/src/complex.rs is no longer changed in the branch
  • experimental/segmenter/src/lib.rs is different
  • experimental/segmenter/src/lstm_bies.rs is different
  • experimental/segmenter/src/lstm.rs is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook[bot] avatar Nov 15 '22 06:11 jira-pull-request-webhook[bot]