icu4x Add lint for debug impls on exported types

Add lint for debug impls on exported types

Open sffc opened this issue 1 year ago • 1 comments

Context: https://github.com/unicode-org/icu4x/pull/2250#discussion_r930774402

Our style guide says that we should implement Debug on all exported types; however, we don't currently do that.

@robertbastian suggested the missing_debug_implementations rustc lint.

@Manishearth thoughts?

Most likely not time for 1.0 but we should try to land it in 1.1

Jul 27 '22 21:07 sffc

Yeah, seems like a good idea!

Jul 27 '22 21:07 Manishearth

Is this 1.2 blocking?

Feb 23 '23 00:02 robertbastian

@sffc - Is this a property we want to retain in the style guide?
@Manishearth - I think it's helpful when things have debug impls, but the debug impls don't necesarily need to be useful. But what it helps is that derive(Debug) can work.
@nordzilla - I strongly prefer it when everything has a Debug impl.

Mar 16 '23 18:03 sffc