icu4x icon indicating copy to clipboard operation
icu4x copied to clipboard

Published 20 hours ago • verified publisher icon unicode-org

Add better WASM test coverage

Open sffc opened this issue 2 years ago • 2 comments

The layout of the ICU4XPluralOperands struct changed in https://github.com/unicode-org/icu4x/pull/1100, and yet it was not necessary to make any changes to the tests. This suggests that the test coverage for this corner of the WASM API is weak. We should add more thorough tests.

Related: https://github.com/rust-diplomat/diplomat/issues/91

sffc avatar Sep 25 '21 00:09 sffc

@Manishearth added test on the Diplomat side for this. https://github.com/rust-diplomat/diplomat/pull/95

sffc avatar Oct 21 '21 18:10 sffc

If folks want to work on this, it essentially involves adding more tests like https://github.com/unicode-org/icu4x/blob/main/ffi/diplomat/wasm/test/fixed-decimal.mjs , perhaps one for plural rules that tries all kinds of plural options. We have some plural rules tests in the cpp folder you can start out with.

Manishearth avatar Oct 22 '21 15:10 Manishearth