icu icon indicating copy to clipboard operation
icu copied to clipboard

Published 20 hours ago • verified publisher icon unicode-org

Wasm32 Architeture Port

Open mabels opened this issue 6 years ago • 7 comments

Hi,

last week I forked icu to do a "Prove of Concept Dive" how to build icu as wasm artefact. And "Steven R. Loomis"(thx again) reviewed my "PoC".

Here is the first working and hopefully properbly done wasm port.

The current status it is not completed yet:

  • make check is not tested
  • i need to test the intergration into my npm modules

But the direction of the port to wasm hopefully done now.

So it would be awesome if you could review this again.

FYI I crafted/published these two npm modules: https://www.npmjs.com/package/wasm-libicu https://www.npmjs.com/package/wasm-intl

I would be awesome if somebody could verify these artefacts if they are conform with the terms of icu license requirements. And give me some feedback if there are any things(license context) to change are need. Reminde both distribute a binary artefact of icu.

Thx in advance

Meno

mabels avatar Aug 28 '19 11:08 mabels

Notice: the branch changed across the force-push!

  • .ci-builds/.azure-pipelines.yml is different
  • icu4c/source/configure is different
  • icu4c/source/i18n/double-conversion-utils.h is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook[bot] avatar Oct 30 '19 10:10 jira-pull-request-webhook[bot]

@mabels

  1. please fix the conflict
  2. please add to the nodejs-system.js:
// © 2016 and later: Unicode, Inc. and others.
// License & terms of use: http://www.unicode.org/copyright.html
  1. will need to be one commit, with the JIRA ticket ( ICU-00000 etc ) at the beginning of the comment

srl295 avatar Mar 24 '20 22:03 srl295

@devsnek was also interested in this.

sffc avatar Sep 24 '20 03:09 sffc

@devsnek was also interested in this.

+1 for @devsnek

srl295 avatar Sep 24 '20 04:09 srl295

Also interested in this. @mabels @markusicu any interest in finalizing these? Looks like there are already have been a few changes that would negative some changes in this PR

arsnyder16 avatar Oct 19 '21 01:10 arsnyder16

@arsnyder16 I haven't seen any response to my review notes from two years ago. (@mabels ?)

But yes, if there's any follow up work from https://github.com/unicode-org/icu/pull/653 ( @tweenk ) that might be the be a better way to proceed

srl295 avatar Oct 19 '21 15:10 srl295

No progress at all after another year. We should probably close this PR. If someone wants to take over, please do so.

markusicu avatar Oct 27 '22 16:10 markusicu