icu icon indicating copy to clipboard operation
icu copied to clipboard

ICU-22837 Update config.guess config.sub for WASI support

Open kateinoigakukun opened this issue 1 year ago • 1 comments

WASI targets (e.g. wasm32-unknown-wasi) are not detected with the current config.guess/config.sub, which date back to 2017.

The latest config.guess and config.sub in https://git.savannah.gnu.org/cgit/config.git have WASI target support, so we need to update them to prepare for the upcoming WASI support patch set.

These files are copied from:

  • https://git.savannah.gnu.org/cgit/config.git/plain/config.guess
  • https://git.savannah.gnu.org/cgit/config.git/plain/config.sub
Checklist
  • [x] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22837
  • [x] Required: The PR title must be prefixed with a JIRA Issue number.
  • [x] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • [x] Required: Each commit message must be prefixed with a JIRA Issue number.
  • [ ] Issue accepted (done by Technical Committee after discussion)
  • [ ] Tests included, if applicable
  • [ ] API docs and/or User Guide docs changed or added, if applicable

kateinoigakukun avatar Jul 25 '24 16:07 kateinoigakukun

@srl295 please compare with upstream; will configure need to be regenerated?

markusicu avatar Aug 15 '24 16:08 markusicu

@srl295 please compare with upstream; will configure need to be regenerated?

In the meantime, @roubert has updated the autoconf scripts, including regenerating the configure script. (https://github.com/unicode-org/icu/pull/3169) This is also why there are merge conflicts here now.

Closing this PR, assuming that there is nothing here except updating a subset of the same files.

markusicu avatar Sep 22 '24 20:09 markusicu