icu icon indicating copy to clipboard operation
icu copied to clipboard
verified publisher icon unicode-org

ICU-22721 Update filtration_test for Python 3.13

Open yselkowitz opened this issue 1 year ago • 4 comments

unittest.makeSuite() was deprecated in Python 3.11 and removed in 3.13: https://docs.python.org/3.13/whatsnew/3.13.html#unittest

Checklist
  • [X] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22721
  • [X] Required: The PR title must be prefixed with a JIRA Issue number.
  • [X] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • [X] Required: Each commit message must be prefixed with a JIRA Issue number.
  • [X] Issue accepted (done by Technical Committee after discussion)
  • [x] Tests included, if applicable
  • [ ] API docs and/or User Guide docs changed or added, if applicable

yselkowitz avatar Jun 21 '24 18:06 yselkowitz

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 21 '24 18:06 CLAassistant

The change looks good, and thanks for making the change. I updated the PR with appropriate details.

The one last thing required is for the commit message to be prefixed with "ICU-22721" followed by a space. Can you do that? If not, one of us can. FWIW, the easiest way to achieve that is to use the PR Checker Bot. In the table of PR checks, in the row that says "jira-ticket", click the "Details" link. The opportunity to squash the one commit won't affect the code, and in this case won't affect the number of commits on the branch, but you can use it to reword the commit message.

echeran avatar Jun 27 '24 16:06 echeran

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook[bot] avatar Jun 27 '24 20:06 jira-pull-request-webhook[bot]

@echeran should be fixed now, all tests passed.

yselkowitz avatar Jul 03 '24 17:07 yselkowitz

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook[bot] avatar Sep 23 '24 20:09 jira-pull-request-webhook[bot]

Hi @echeran

The change looks good, and thanks for making the change. I updated the PR with appropriate details.

The one last thing required is for the commit message to be prefixed with "ICU-22721" followed by a space. [...]

The author did that. It sounds like otherwise you were ready to approve & merge? I just rebased this PR on current main in order to update the PR checks.

@sffc this makes the data build script work on a newer version of Python.

markusicu avatar Sep 23 '24 20:09 markusicu