icu icon indicating copy to clipboard operation
icu copied to clipboard

ICU-22757 Remove allow list of known contractions with precomposed form from ICU4X mode of genuca

Open hsivonen opened this issue 1 year ago • 5 comments

This assumes that future cases will work OK, since the addition that was seen in Unicode 16 alpha was OK.

Checklist
  • [x] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22757
  • [x] Required: The PR title must be prefixed with a JIRA Issue number.
  • [x] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • [x] Required: Each commit message must be prefixed with a JIRA Issue number.
  • [x] Issue accepted (done by Technical Committee after discussion)
  • [ ] Tests included, if applicable
  • [ ] API docs and/or User Guide docs changed or added, if applicable

hsivonen avatar May 08 '24 08:05 hsivonen

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/collationdatabuilder.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Notice: the branch changed across the force-push!

  • icu4c/source/data/in/coll/ucadata-implicithan-icu4x.icu is now changed in the branch
  • icu4c/source/data/in/coll/ucadata-unihan-icu4x.icu is now changed in the branch
  • icu4c/source/data/unidata/generate.sh is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

mostly lgtm I believe that the test failure is due to this PR not also updating the generated binary data files.

Added the generated files to the changeset. Thanks.

hsivonen avatar May 10 '24 13:05 hsivonen

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/collationdatabuilder.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Notice: the branch changed across the force-push!

  • icu4c/source/data/unidata/generate.sh is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot