icu icon indicating copy to clipboard operation
icu copied to clipboard

ICU-22746 Import tests from ICU4J and make more tests data-driven

Open catamorphism opened this issue 9 months ago • 6 comments

This change brings in all the tests from ICU4J (some are marked as "ignored" with a JIRA ticket number, which is a capability I added to the JSON test harness added in #2980 .)

It also includes some code changes: to fix number selection and to fix some of the options for number formatting, which were exposed as not-working by the ICU4J tests. I chose to include these code changes in this PR so that all of the ICU4J tests could be added in one PR.

I put all of the ICU4J tests in a separate subdirectory: testdata/message2/icu4j/ . These files will need to be kept consistent with ICU4J manually (from previous discussions, I understand that there's no way to share test data between ICU4J and ICU4C).

Checklist
  • [x] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22746
  • [x] Required: The PR title must be prefixed with a JIRA Issue number.
  • [x] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • [x] Required: Each commit message must be prefixed with a JIRA Issue number.
  • [x] Issue accepted (done by Technical Committee after discussion)
  • [x] Tests included, if applicable
  • [x] API docs and/or User Guide docs changed or added, if applicable

catamorphism avatar May 07 '24 22:05 catamorphism

cc @echeran @mihnita

catamorphism avatar May 07 '24 22:05 catamorphism

LGTM, thank you.

I think it would be good to share the files somehow, but that is not to be solved here. Before the next release we probably need to change the .json files according to the new schema anyway.

Mihai

mihnita avatar May 10 '24 21:05 mihnita

@markusicu Reviewed, but I can't squash.

I get:

NOTICE: Your previous squash attempt failed with code 404. If you get this error repeatedly, you may not have permission to push to this repository.

mihnita avatar May 10 '24 21:05 mihnita

Optional, @catamorphism : you can squash the 6 commits on your side (making sure the final commit is named "ICU-22746 Import tests from ICU4J and make more tests data-driven") and force-push

mihnita avatar May 10 '24 21:05 mihnita

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Squashed, thanks!

catamorphism avatar May 10 '24 21:05 catamorphism

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

I've rebased and force-pushed, which Mihai suggested in order to fix the MSYS2 GCC build failure.

catamorphism avatar May 13 '24 21:05 catamorphism