icu icon indicating copy to clipboard operation
icu copied to clipboard

ICU-22001 Put translation unit local definitions in unnamed namespaces

Open roubert opened this issue 1 year ago • 0 comments

Any symbol that isn't intended to have external linkage should either be declared static (legacy code) or put in an unnamed namespace.

Checklist
  • [x] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22001
  • [x] Required: The PR title must be prefixed with a JIRA Issue number.
  • [x] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • [x] Required: Each commit message must be prefixed with a JIRA Issue number.
  • [x] Issue accepted (done by Technical Committee after discussion)
  • [ ] Tests included, if applicable
  • [ ] API docs and/or User Guide docs changed or added, if applicable

roubert avatar Apr 24 '24 20:04 roubert