icu icon indicating copy to clipboard operation
icu copied to clipboard

ICU-21458 icu4c support for macOS @rpath

Open evanmiller opened this issue 2 years ago • 3 comments

On Darwin:

--enable-rpath incorrectly uses an absolute path rather than an @rpath prefix.

--disable-rpath incorrectly uses a relative path rather than an absolute path. It also uses $(PKGDATA_TRAILING_SPACE) unnecessarily.

See downstream MacPorts discussion here: https://github.com/macports/macports-ports/pull/18696

Checklist
  • [x] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-21458
  • [x] Required: The PR title must be prefixed with a JIRA Issue number.
  • [x] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • [x] Required: Each commit message must be prefixed with a JIRA Issue number.
  • [ ] Issue accepted (done by Technical Committee after discussion)
  • [ ] Tests included, if applicable
  • [ ] API docs and/or User Guide docs changed or added, if applicable

evanmiller avatar May 20 '23 16:05 evanmiller

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 20 '23 16:05 CLAassistant

@garywade

markusicu avatar May 25 '23 16:05 markusicu

@evanmiller makes sense, thanks for fixing this very longstanding issue!

srl295 avatar May 26 '23 19:05 srl295