ICU-22319 Fix number range semanticallyEquivalent

[sffc]

There was a bug that was sometimes causing semantically equivalent modifiers to not be recognized as semantically equivalent. It was checking for pointer equality instead of semantic equality.

Checklist

• [x] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22319
• [x] Required: The PR title must be prefixed with a JIRA Issue number.
• [x] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
• [ ] Required: Each commit message must be prefixed with a JIRA Issue number.
• [ ] Issue accepted (done by Technical Committee after discussion)
• [x] Tests included, if applicable
• [ ] API docs and/or User Guide docs changed or added, if applicable

[sffc]

@richgillam Assigned this to you to review since it is in number formatting code. No rush because I don't expect this to land in ICU 73 unless the team specifically wants it in there.

[jira-pull-request-webhook[bot]]

Notice: the branch changed across the force-push!

• icu4c/source/test/intltest/numbertest.h is different
• icu4j/main/classes/core/src/com/ibm/icu/impl/number/ConstantAffixModifier.java is no longer changed in the branch
• icu4j/main/classes/core/src/com/ibm/icu/impl/number/ConstantMultiFieldModifier.java is no longer changed in the branch
• icu4j/main/classes/core/src/com/ibm/icu/impl/number/Modifier.java is no longer changed in the branch
• icu4j/main/classes/core/src/com/ibm/icu/impl/number/MutablePatternModifier.java is no longer changed in the branch
• icu4j/main/classes/core/src/com/ibm/icu/impl/number/SimpleModifier.java is no longer changed in the branch
• icu4j/main/classes/core/src/com/ibm/icu/number/NumberRangeFormatterImpl.java is no longer changed in the branch
• icu4j/main/classes/core/src/com/ibm/icu/number/ScientificNotation.java is no longer changed in the branch
• icu4j/main/core/src/main/java/com/ibm/icu/impl/number/ConstantAffixModifier.java is now changed in the branch
• icu4j/main/core/src/main/java/com/ibm/icu/impl/number/ConstantMultiFieldModifier.java is now changed in the branch
• icu4j/main/core/src/main/java/com/ibm/icu/impl/number/Modifier.java is now changed in the branch
• icu4j/main/core/src/main/java/com/ibm/icu/impl/number/MutablePatternModifier.java is now changed in the branch
• icu4j/main/core/src/main/java/com/ibm/icu/impl/number/SimpleModifier.java is now changed in the branch
• icu4j/main/core/src/main/java/com/ibm/icu/number/NumberRangeFormatterImpl.java is now changed in the branch
• icu4j/main/core/src/main/java/com/ibm/icu/number/ScientificNotation.java is now changed in the branch
• icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberRangeFormatterTest.java is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

[sffc]

I rebased this on main. A bunch of Java files moved around.

[markusicu]

I rebased this on main. A bunch of Java files moved around.

recte: all Java files have moved around ;-)

[sffc]

@markusicu Once you approve I will squash.

[jira-pull-request-webhook[bot]]

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

[jira-pull-request-webhook[bot]]

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

[sffc]

Force-pushed to bump CI. When it passes please feel free to merge