icu icon indicating copy to clipboard operation
icu copied to clipboard

ICU-22159 Merge inDaylightTime to Calendar

Open FrankYFTang opened this issue 3 years ago • 2 comments

All the subclass implementation of inDaylightTime are the same so just move to a base class implementation.

Checklist
  • [X] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22159
  • [X] Required: The PR title must be prefixed with a JIRA Issue number.
  • [X] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • [X] Required: Each commit message must be prefixed with a JIRA Issue number.
  • [ ] Issue accepted (done by Technical Committee after discussion)
  • [ ] Tests included, if applicable
  • [ ] API docs and/or User Guide docs changed or added, if applicable

FrankYFTang avatar Sep 22 '22 03:09 FrankYFTang

no urgent need for 72. we should wait for 73.

FrankYFTang avatar Sep 22 '22 03:09 FrankYFTang

no urgent need for 72. we should wait for 73.

This must wait for 73 since we are after the 72 code freeze, and this cannot be merged to main until the maint/maint-72 branch is created. I will wait to review until then.

pedberg-icu avatar Sep 22 '22 04:09 pedberg-icu

@FrankYFTang looks ready to merge for ICU 73.

markusicu avatar Oct 27 '22 16:10 markusicu