ICU-22068 Cleanup inconsistent annotations between declarations and d…

[cyndyishida]

…efinitions

This cleans up inconsistent annotations between declared APIs in headers vs defined implementations in cpp's. This better ensures the API's referenceable in headers represent what is exposed and defined in the ultimate binary library's symbol table.

• [x] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22068
• [x] Required: The PR title must be prefixed with a JIRA Issue number.
• [x] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
• [x] Required: Each commit message must be prefixed with a JIRA Issue number.
• [x] Issue accepted (done by Technical Committee after discussion)
• [x] Tests included, if applicable (current regression tests should suffice)
• [ ] API docs and/or User Guide docs changed or added, if applicable

[jira-pull-request-webhook[bot]]

Notice: the branch changed across the force-push!

• icu4c/source/common/unicode/utf_old.h is different
• icu4c/source/stubdata/BUILD.bazel is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

[jira-pull-request-webhook[bot]]

Notice: the branch changed across the force-push!

• icu4c/source/common/unicode/utf_old.h is different
• icu4c/source/common/utf_impl.cpp is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

[cyndyishida]

Waiting on @markusicu feedback before moving forward.

[pedberg-icu]

@markusicu You probably want to have a look at this one.

[markusicu]

Is it possible to add "TAPI" to a build bot, so that these kinds of things don't backslide?

[cyndyishida]

Is it possible to add "TAPI" to a build bot, so that these kinds of things don't backslide?

I would love to add TAPI to ICU's CI! Unfortunately the tool itself only works out of the box with Xcode. The tool hasn't been completely upstreamed as apart of LLVM (slowly working on this). I'd love to touch base again after we've finished open sourcing TAPI as apart of LLVM's toolchain to get this supported.

[markusicu]

Also, there is a merge conflict. Please rebase & resolve.

[jira-pull-request-webhook[bot]]

Notice: the branch changed across the force-push!

• icu4c/source/i18n/collationbuilder.cpp is different
• icu4c/source/i18n/collationdatabuilder.cpp is different
• icu4c/source/stubdata/stubdata.h is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot