icu ICU-21755 commit checker: add support for COMMIT

ICU-21755 commit checker: add support for COMMIT_METADATA.md file

Open srl295 opened this issue 2 years ago • 11 comments

ICU-21755

new option, --commit-metadata= with path to metadata file
new option, --fix-version=41 (used for SKIP sections)
scaffolding for 'bad commits' list
new module CommitMetadata with unit tests
sample file format TEST_COMMIT_METADATA.md
such commits are skipped
refactored the commit skipping part (formerly used for cherry pick skips)
add a report section for skipped commits
add a cache for JIRA queries (for dev use): --cache-for-dev "/tmp/cldr-commit-cache"
add an 'excluded commits' section at the bottom

See https://github.com/unicode-org/cldr/pull/1790 for an example of use and output reports.

Mar 11 '22 15:03 srl295

@sffc knowing this is controversial in the ticket, we might just keep this open for CLDR's v41 timeframe, and then sort out a landing strategy during/after that.

In other words, I'm not blocked on this landing in the near future, but will just use this branch for CLDR's use, while we asynchronously work out what should actually land.

Mar 11 '22 15:03 srl295

Hi @sffc … any comments on this? CLDR has been using it for a month or so using https://github.com/unicode-org/cldr/blob/maint/maint-41/.github/COMMIT_METADATA.md

Apr 06 '22 14:04 srl295

Would this be a good time to split out the commit checker to its own repo? that way at least we could have a cldr and an icu branch in that repo representing the latest… and then just cross merge as best as possible.

Apr 06 '22 14:04 srl295

@sffc ping? is your preference to fork the commit checker?

Jul 26 '22 15:07 srl295

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot