icu
icu copied to clipboard
unicode-org
ICU-20926 Adding test to verify fallback rule of DateIntervalFormat
Checklist
- [x] Issue filed: https://unicode-org.atlassian.net/browse/ICU-20926
- [x] Updated PR title and link in previous line to include Issue number
- [x] Issue accepted
- [x] Tests included
- [ ] Documentation is changed or added
Cc @sffc
I added tests with some skeletons, however I was not able to find the skeleton that would result in the same pattern we get from DateFormate::createTimeInstance (DateFormat::kFull, DateFormat::kFull, locale);. Considering the test as it is, it is passing. After I get green light for it, I'll add Java version of this test.
Is the Java test already have this? If not, could you also add the same test to ICU4J.
Good, this is the first half of what the ticket is requesting that we test. The second half:
We should add a test for this behavior: UFIELD_CATEGORY_DATE_INTERVAL_SPAN should be present in the UFormattedValue if and only if a date interval was formatted. If the field is not present, then that should imply that no date interval was formatted.
Can you check for UFIELD_CATEGORY_DATE_INTERVAL_SPAN and test that it is present if and only if a date interval was formatted?
@caiolima Do you have plans to respond to the feedback on this PR?
Oops, I feel this got lost in my notification list for quite a while. I'm quite busy on other tasks and I don't think will be able to work there in the near term.
I updated the branch and responded to the feedback in https://github.com/unicode-org/icu/pull/2245.