cldr icon indicating copy to clipboard operation
cldr copied to clipboard

CLDR-5854 First attempt with examples for two cases per item

Open haytenf opened this issue 1 year ago • 1 comments

CLDR-5854

Locale Before After
cy Screenshot 2024-08-27 at 4 33 56 PM Screenshot 2024-08-27 at 4 34 32 PM
cy Screenshot 2024-08-27 at 4 35 20 PM Screenshot 2024-08-27 at 4 50 53 PM
cy Screenshot 2024-08-27 at 4 36 47 PM Screenshot 2024-08-27 at 4 37 19 PM
cy Screenshot 2024-08-27 at 4 43 45 PM Screenshot 2024-08-27 at 4 46 19 PM
cy Screenshot 2024-08-27 at 4 53 20 PM Screenshot 2024-08-27 at 4 39 28 PM
ro Screenshot 2024-08-27 at 4 56 03 PM Screenshot 2024-08-27 at 4 57 18 PM
ro Screenshot 2024-08-27 at 4 56 21 PM Screenshot 2024-08-27 at 4 57 54 PM
ro Screenshot 2024-08-27 at 5 02 07 PM (future-few) Screenshot 2024-08-27 at 5 01 05 PM
ro Screenshot 2024-08-27 at 4 59 38 PM Screenshot 2024-08-27 at 5 03 43 PM
it Screenshot 2024-08-27 at 5 05 34 PM Screenshot 2024-08-27 at 5 06 23 PM
it Screenshot 2024-08-27 at 5 06 51 PM Screenshot 2024-08-27 at 5 07 40 PM
  • [ ] This PR completes the ticket.

ALLOW_MANY_COMMITS=true

haytenf avatar Aug 27 '24 20:08 haytenf

@macchiati @srl295 This is just an initial attempt at the ticket based on my understanding. It doesn't fully cover the context/casing purpose (which might need to be split out into a separate ticket). If you take a look at the example screenshots in the markdown table (specifically the images for Romanian), there are two reasons I'm noticing why it won't cover the context/casing side:

  1. simple date format produces the date appropriately lowercased for Romanian, which is then formatted with the relative item, so the middle-of-sentence capitalization issue doesn't arise

  2. the pattern I use for some of the examples is MMMMd, and when formatted using the rules for Romanian d comes first, so the capitalization becomes irrelevant

In terms of just getting examples in for the relative items, it might still be a starting point. I still need to get a few more tests in and clean up the code but wanted to get feedback design wise.

haytenf avatar Aug 27 '24 21:08 haytenf

@macchiati @srl295 This is just an initial attempt at the ticket based on my understanding. It doesn't fully cover the context/casing purpose (which might need to be split out into a separate ticket). If you take a look at the example screenshots in the markdown table (specifically the images for Romanian), there are two reasons I'm noticing why it won't cover the context/casing side:

  1. simple date format produces the date appropriately lowercased for Romanian, which is then formatted with the relative item, so the middle-of-sentence capitalization issue doesn't arise
  2. the pattern I use for some of the examples is MMMMd, and when formatted using the rules for Romanian d comes first, so the capitalization becomes irrelevant

In terms of just getting examples in for the relative items, it might still be a starting point. I still need to get a few more tests in and clean up the code but wanted to get feedback design wise.

@btangmu @srl295 @macchiati Just wanted to follow up and see if anyone has any input about the new examples from this.

haytenf avatar Sep 09 '24 16:09 haytenf