CLDR-17111 Deprecate old style zone IDs (e.g. EST5EDT, EET)

[justingrant]

CLDR-17111

• [ ] This PR completes the ticket.

ALLOW_MANY_COMMITS=true

This PR adds a commit to #3736 (cc @yumaoka) to align CLDR's aliases for recently deprecated zones to match IANA's Link=>Zone mappings in the following recent commits:

https://github.com/eggert/tz/commit/782d082623aaa130178d944bdbfbb563d2e1adfa https://github.com/eggert/tz/commit/a0b09c0230089252acf2eb0f1ba922e99f7f4a03

It also fixes tests broken by these deprecations.

[yumaoka]

The changes look fine. All changes are aligned to what IANA TZ database maintainer agreed with. Because you already have the correct changes, I'll close my PRs previously created.

For ICU testing - we'll find out if there are any changes required on ICU side after this is merged. I don't think CLDR test fails with this change.

[justingrant]

The changes look fine. All changes are aligned to what IANA TZ database maintainer agreed with. Because you already have the correct changes, I'll close my PRs previously created.

Great! Glad we were able to resolve this upstream. Easier for everyone.

For ICU testing - we'll find out if there are any changes required on ICU side after this is merged. I don't think CLDR test fails with this change.

Yep, fixing the CLDR tests was thankfully easy: it only required adding EST5EDT, etc. zones to the deprecated-zone exception list in TestLocale.java. I can confirm that tests failed before this test-code change and passed afterwards.

[yumaoka]

@justingrant Are you waiting for someone to merge this? There is an issues in this PR. First, you have a commit with a comment not starting with CLDR-17111. Can you fix this? It is not a requirement to squash changes into one, but for this change, it's probably a good idea to do so.

If you are not able to do this, I can create a separate PR and merge it. I cannot modify the branch, so that's only the solution if you're not going to correct PR issues and merge it.

[jira-pull-request-webhook[bot]]

Notice: the branch changed across the force-push!

• common/supplemental/supplementalMetadata.xml is different
• tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestLocale.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

[jira-pull-request-webhook[bot]]

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

[justingrant]

@justingrant Are you waiting for someone to merge this?

Yep! Also, I don't have permissions to run the GH build and test actions so someone will need to run those.

you have a commit with a comment not starting with CLDR-17111

Fixed!

not a requirement to squash changes into one, but for this change, it's probably a good idea to do so.

Sqaushed and rebased to main.

Let me know if there's anything more that I need to do. Thanks @yumaoka!