unicode-org
CLDR-17566 Converting development process to markdown
The conversion is generally good but a lot of the content is out of date. Getting it moved over, though is a good step towards improvement.
Just to be clear, Chris's goal is to make sure that the text and formatting are the same as the original, correcting the formatting where sites has messed it up.
So he should not be trying to make any fixes to the text. That is for us to do later.
On Mon, May 13, 2024, 07:16 Steven R. Loomis @.***> wrote:
@.**** commented on this pull request.
In docs/site/development/development-process.md https://github.com/unicode-org/cldr/pull/3712#discussion_r1598553171:
+--- +title: Handling Tickets (bugs/enhancements) +---
If this shows up in the output (I don't think it will) I can fix the conversion process.
— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3712#pullrequestreview-2052838691, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMBRROGDFVM6BHT22ITZCDDL3AVCNFSM6AAAAABHSD6Q42VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJSHAZTQNRZGE . You are receiving this because you were mentioned.Message ID: @.***>
I believe this resolves the changes you guys were talking about. @macchiati, I am a bit confused as to what I should put for the diffs between the plain texts. I tried your suggestion with Google Docs history but it doesn't ignore whitespace so I couldn't get it to work and was just using a browser tool. Let me know what I should link to.
Hmmm.
We'd like to give the reviewer confidence that the plaintext is preserved. One idea would be to normalize the spaces in both eg:
[ \t]+ => space [ \t]\n[ \t] => \n
Alternatively, we could make a side PR, checking in the original plaintext in one commit, and the generated plaintext in a second. Then people can use the github diff (which can ignore whitespace).
Any other ideas?
On Wed, May 22, 2024 at 4:18 PM Chris Pyle @.***> wrote:
I believe this resolves the changes you guys were talking about. @macchiati https://github.com/macchiati, I am a bit confused as to what I should put for the diffs between the plain texts. I tried your suggestion with Google Docs history but it doesn't ignore whitespace so I couldn't get it to work and was just using a browser tool. Let me know what I should link to.
— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3712#issuecomment-2125931763, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMFO4OUZZF4THRSC4ITZDURTTAVCNFSM6AAAAABHSD6Q42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRVHEZTCNZWGM . You are receiving this because you were mentioned.Message ID: @.***>
I looked into it some more and it seems like the history on google docs just looks at what the user did not the differences, so even if you copy in the same text the history looks like deleting and re-entering. Another option would be to include a screenshot of my diff tool in the comment. This might not be as convincing as a PR but would be faster.
A screen shot would work, good idea.
On Wed, May 22, 2024 at 4:44 PM Chris Pyle @.***> wrote:
I looked into it some more and it seems like the history on google docs just looks at what the user did not the differences, so even if you copy in the same text the history looks like deleting and re-entering. Another option would be to include a screenshot of my diff tool in the comment. This might not be as convincing as a PR but would be faster.
— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3712#issuecomment-2125952048, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMDPBFQJ3KT7M6XNLSTZDUUVLAVCNFSM6AAAAABHSD6Q42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRVHE2TEMBUHA . You are receiving this because you were mentioned.Message ID: @.***>