cldr icon indicating copy to clipboard operation
cldr copied to clipboard

CLDR-17626 Fix day periods for Sicilian (scn), and provide initial data.

Open dpaleino opened this issue 9 months ago • 7 comments

CLDR-17626

  • [X] This PR completes the ticket.

ALLOW_MANY_COMMITS=true

dpaleino avatar May 11 '24 13:05 dpaleino

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 11 '24 13:05 CLAassistant

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

thanks! The translations should be provided through the Survey Tool which is open now (as of yesterday). If you don't have an account to contribute under scn you can file for one at https://corp.unicode.org/reporting/cldr-id.html

srl295 avatar May 16 '24 17:05 srl295

Notice: the branch changed across the force-push!

  • common/main/scn.xml is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Generally LGTM but I'd drop the scn.xml changes - should be in surveytool

Yup, done! I have an account (actually, I'm also waiting for the creation of an org account, but that's another issue), but I thought it would make sense to also commit some defaults.

It'd be extra nice to have this in v46, since the AM/PM issue is the only missing bit to have Basic coverage.

Thank you for considering!

dpaleino avatar May 16 '24 21:05 dpaleino

Great, if we didn’t discuss this already go ahead and put data in even if you don’t have your organization account yet, we can transfer your account over later

El El jue, may 16, 2024 a la(s) 4:29 p.m., David Paleino < @.***> escribió:

Generally LGTM but I'd drop the scn.xml changes - should be in surveytool

Yup, done! I have an account (actually, I'm also waiting for the creation of an org account, but that's another issue), but I thought it would make sense to also commit some defaults.

It'd be extra nice to have this in v46, since the AM/PM issue is the only missing bit to have Basic coverage.

Thank you for considering!

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3710#issuecomment-2116221632, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGQZM2MYP5D2JLNKJME4P3ZCUQLRAVCNFSM6AAAAABHR6KRVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWGIZDCNRTGI . You are receiving this because you commented.Message ID: @.***>

srl295 avatar May 16 '24 23:05 srl295

Yes, I'm doing that already, it's just that each and every time I checked the survey tool was closed... this time I could manage to remember to check and also find free time while it was open 😀

Thank you for reviewing the patch! David

(btw the issue regarding the org account is from 2020 🤣)

Il Ven 17 Mag 2024, 01:16 Steven R. Loomis @.***> ha scritto:

Great, if we didn’t discuss this already go ahead and put data in even if you don’t have your organization account yet, we can transfer your account over later

El El jue, may 16, 2024 a la(s) 4:29 p.m., David Paleino < @.***> escribió:

Generally LGTM but I'd drop the scn.xml changes - should be in surveytool

Yup, done! I have an account (actually, I'm also waiting for the creation of an org account, but that's another issue), but I thought it would make sense to also commit some defaults.

It'd be extra nice to have this in v46, since the AM/PM issue is the only missing bit to have Basic coverage.

Thank you for considering!

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3710#issuecomment-2116221632,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAGQZM2MYP5D2JLNKJME4P3ZCUQLRAVCNFSM6AAAAABHR6KRVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWGIZDCNRTGI>

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3710#issuecomment-2116360653, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAJ27JG7JNBVF76YQVW55LZCU44LAVCNFSM6AAAAABHR6KRVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWGM3DANRVGM . You are receiving this because you authored the thread.Message ID: @.***>

dpaleino avatar May 17 '24 12:05 dpaleino