cldr icon indicating copy to clipboard operation
cldr copied to clipboard
verified publisher icon unicode-org

CLDR-17399 Migrate from deprecated boxed primitive constructors

Open mihnita opened this issue 1 year ago • 6 comments

CLDR-17399

  • [x] This PR completes the ticket.

ALLOW_MANY_COMMITS=true

mihnita avatar Feb 24 '24 09:02 mihnita

Were these changes generated by a refactoring tool or ide?

On Sat, Feb 24, 2024, 01:28 Mihai Nita @.***> wrote:

CLDR-17399 https://unicode-org.atlassian.net/browse/CLDR-17399

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

You can view, comment on, or merge this pull request online at:

https://github.com/unicode-org/cldr/pull/3520 Commit Summary

File Changes

(35 files https://github.com/unicode-org/cldr/pull/3520/files)

Patch Links:

  • https://github.com/unicode-org/cldr/pull/3520.patch
  • https://github.com/unicode-org/cldr/pull/3520.diff

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3520, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMBBRC5YU4WSGBZSXETYVGXEDAVCNFSM6AAAAABDX32W66VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2TEMRTGAZTAMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

macchiati avatar Feb 24 '24 15:02 macchiati

org.json is external but has already diverged

srl295 avatar Feb 24 '24 23:02 srl295

needs mvn spotless:apply

srl295 avatar Feb 24 '24 23:02 srl295

Were these changes generated by a refactoring tool or ide?

I wish :-)

Detected by erroprone. I added a profile for maven so that we can run from command line. (not a friendly report though)

I use the report as a guideline, but did the fixes in IntelliJ, with assistance. Could have accepted the fixes "as is", but they were not always the best option.

For example:

Integer foo = new Integer(123);

Proposed fix:

Integer foo = Integer.valueOf(123);

But that only introduced another errorprone issue (not reported if you limit yourself to test for a one issue type only). What I did in the end was:

Integer foo = 123;

TLDR: IDE assisted

mihnita avatar Feb 26 '24 20:02 mihnita

org.json is external but has already diverged I will reconcile.

needs mvn spotless:apply Done. I didn't know about it, I don't touch CLDR too much (at all :-).

Thanks, M

mihnita avatar Feb 26 '24 20:02 mihnita

Should I drop org.json, if it is external?

mihnita avatar Feb 26 '24 20:02 mihnita