cldr
cldr copied to clipboard
CLDR-16232 Add test for inheritance and bailey values
CLDR-16232
- [ ] This PR completes the ticket.
ALLOW_MANY_COMMITS=true
great! I'll focus on why the test fails, and possible ways to make it pass
Good. I should have a chance on the plane to add more types of inheritance.
On Thu, Dec 22, 2022, 06:58 Tom Bishop @.***> wrote:
great! I'll focus on why the test fails, and possible ways to make it pass
— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/2628#issuecomment-1362939109, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMFBAWQW6ZBXUDW7B73WORUC7ANCNFSM6AAAAAATGHFDFY . You are receiving this because you authored the thread.Message ID: @.***>
This won't pass until we fix inheritance problems (see Tom's PR)
Hooray! The files in the branch are the same across the force-push. 😃
~ Your Friendly Jira-GitHub PR Checker Bot
test seems reasonable, so it is accurately showing the issue, where the triple up arrow follows the programatic alias to the 'other' unit
Error: (TestAliases.java:33) Error: : en_001 //ldml/units/unitLength[@type="short"]/unit[@type="duration-hour"]/unitPattern[@count="one"] {0} hrx null: expected "{0} hrx", got "{0} hrxs"
[174](https://github.com/unicode-org/cldr/actions/runs/3819571247/jobs/6497239237#step:16:175)
[175](https://github.com/unicode-org/cldr/actions/runs/3819571247/jobs/6497239237#step:16:176)
Error: (TestAliases.java:33) Error: : en_001 //ldml/units/unitLength[@type="short"]/unit[@type="duration-hour"]/unitPattern[@count="one"] {0} hrx ↑↑↑: expected "{0} hrx", got "{0} hrxs"
[176](https://github.com/unicode-org/cldr/actions/runs/3819571247/jobs/6497239237#step:16:177)
[177](https://github.com/unicode-org/cldr/actions/runs/3819571247/jobs/6497239237#step:16:178)
Error: (TestAliases.java:33) Error: : de_AT //ldml/units/unitLength[@type="long"]/unit[@type="duration-day-person"]/unitPattern[@count="one"][@case="genitive"] {0} Tagx null: expected "{0} Tagx", got "{0} Tagxx"
[178](https://github.com/unicode-org/cldr/actions/runs/3819571247/jobs/6497239237#step:16:179)
[179](https://github.com/unicode-org/cldr/actions/runs/3819571247/jobs/6497239237#step:16:180)
Error: (TestAliases.java:33) Error: : de_AT //ldml/units/unitLength[@type="long"]/unit[@type="duration-day-person"]/unitPattern[@count="one"][@case="genitive"] {0} Tagx ↑↑↑: expected "{0} Tagx", got "{0} Tagxx"
[180](https://github.com/unicode-org/cldr/actions/runs/3819571247/jobs/6497239237#step:16:181)
Notice: the branch changed across the force-push!
- tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAliases.java is different
~ Your Friendly Jira-GitHub PR Checker Bot
Notice: the branch changed across the force-push!
- tools/cldr-code/src/main/java/org/unicode/cldr/util/DtdData.java is different
~ Your Friendly Jira-GitHub PR Checker Bot
@macchiati @srl should we revisit this draft pr by Mark? it's connected to a major-stretch ticket, but might it be valuable for the current blocks-progress inheritance tickets under https://unicode-org.atlassian.net/browse/CLDR-16537 ?
Notice: the branch changed across the force-push!
- tools/cldr-code/src/main/java/org/unicode/cldr/util/CLDRFile.java is now changed in the branch
- tools/cldr-code/src/main/java/org/unicode/cldr/util/DtdData.java is different
- tools/cldr-code/src/main/java/org/unicode/cldr/util/XMLSource.java is different
- tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAliases.java is different
~ Your Friendly Jira-GitHub PR Checker Bot
Notice: the branch changed across the force-push!
- tools/cldr-code/src/main/java/org/unicode/cldr/util/DtdData.java is different
- tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAliases.java is no longer changed in the branch
~ Your Friendly Jira-GitHub PR Checker Bot