cldr icon indicating copy to clipboard operation
cldr copied to clipboard

CLDR-14199 Add new locale file shn.xml to seed/main

Open i18ncraig opened this issue 4 years ago • 10 comments

CLDR-14199 Add new Myanmar locale file for Shan (ISO shn) to seed/main.

Checklist
  • [X] Issue filed: https://unicode-org.atlassian.net/browse/CLDR-14199
  • [X] Updated PR title and link in previous line to include Issue number

i18ncraig avatar Mar 04 '21 01:03 i18ncraig

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 04 '21 01:03 CLAassistant

commit message needs to also be:

CLDR-14199 Add new locale file shn.xml to seed/main

srl295 avatar Mar 04 '21 18:03 srl295

fails validation:

$ java -jar tools/cldr-code/target/cldr-code.jar validate ./seed/main/shn.xml
>> org.unicode.cldr.util.XMLValidator
Note: CLDR_DIR was unset but you seem to be in a CLDR directory. Setting -DCLDR_DIR=.
# 1 file(s) to check
/Users/srl295/src/cldr2/seed/main/shn.xml:9304:8: ERROR: Element null is not valid because The content of element type "ldml" must match "(identity,(alias|(fallback*,localeDisplayNames?,layout?,contextTransforms?,characters?,delimiters?,measurement?,dates?,numbers?,units?,listPatterns?,collations?,posix?,characterLabels?,segmentations?,rbnf?,typographicNames?,annotations?,metadata?,references?,special*)))".
# 1 file(s) OK

srl295 avatar Mar 04 '21 18:03 srl295

I can't really review the file effectively due to UI sluggishness, but a few things:

  • <localeDisplayNames> ends too early. Then, there are additional <language … > entries that all need ot be within localeDisplayNames.
  • there are <script type=… elements that should be inside <scripts/> which should be inside <localeDisplayNames/>

I'm not sure what the source of this data is, but it might be better to start with a smaller file, make sure it passes validation, then keep adding data to it.

srl295 avatar Mar 04 '21 18:03 srl295

you can download the .jar file needed here (or later versions): http://unicode.org/Public/cldr/38.1/ -you can download and use cldr-code.jar for validation

srl295 avatar Mar 04 '21 18:03 srl295

@i18ncraig ?

srl295 avatar Aug 16 '21 18:08 srl295

I had Git problems on my machine. About the time I got these fixed, I though it was past the deadline to address this ticket. Is there still time for the repair of shn.xml?

i18ncraig avatar Aug 18 '21 05:08 i18ncraig

@srl295 Hi Steven, I just found this link to this page now. Are you able to add blank xml for Shan language ? That XML file is from us (Shan Institute of Information Technology(SIIT)). I was just checking the status on Jira. :D

SZTSIIT avatar Dec 04 '21 04:12 SZTSIIT

@I18ncraig can you update it ?

srl295 avatar Dec 04 '21 14:12 srl295

I cannot. Peter E and I tried to get me unblocked. No joy. Someone else needs to check this in, please. Note there was a problem with the file (unmatched parens or the like). Run through the Java checker first.

On Sat, Dec 4, 2021 at 6:18 AM Steven R. Loomis @.***> wrote:

@i18ncraig https://github.com/i18ncraig can you update it ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/1084#issuecomment-986035328, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATB6IZ2EFUSK4NADOKKPZR3UPIPL7ANCNFSM4YSJUHLA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

i18ncraig avatar Dec 09 '21 05:12 i18ncraig

Superseded by #2159

srl295 avatar Sep 07 '22 21:09 srl295