ungoogled-chromium-windows icon indicating copy to clipboard operation
ungoogled-chromium-windows copied to clipboard

Is new_version_check.yml needed?

Open PF4Public opened this issue 2 years ago • 9 comments

Would it be beneficial to have an adapted (linux → win) copy of new_version_check.yml from main repo here?

Sometimes Windows stable updated do not correspond to Linux updates. At the moment Windows is ahead of Linux at 103.0.5060.66 for example.

PF4Public avatar Jul 01 '22 10:07 PF4Public

Yes, that would be great. The quest is if the version check should be implemented here or in the core repo. I don't know if the patches of the core repo can be applied to a more recent (windows) chromium version.

teeminus avatar Jul 01 '22 10:07 teeminus

Yea we probably at least need to shuffle some line number around.

I'd say we add it to the core repo with an additional windows tag and just require a review checking if it builds and runs from the windows team

Apparently you can also assign teams in an issue template so that would be fitting

networkException avatar Jul 01 '22 11:07 networkException

Wouldn't the core repo profit from using a more recent version of chromium as well? Sure, it's likely that only windows problems are addressed in the windows release, but I think it would not make the Linux version worse. Besides having an other build number than the official chrome release.

teeminus avatar Jul 01 '22 11:07 teeminus

I'm not sure if we want to do that as it could accidentally introduce regressions that nobody else has on linux

networkException avatar Jul 01 '22 11:07 networkException

Another thing would be that using non-released versions for a platform could somehow negate the efforts of hardening the fingerprinting, although I cannot estimate to which degree.

I don't know if the patches of the core repo can be applied to a more recent (windows) chromium version.

Minor releases usually apply as is for Linux, should be the same for Windows.

And by the way I forgot that Windows repo relies heavily on the core one. Probbably this version check should go into core then, but what do we do if both release with the same version: two issues? That's too much :( Maybe adapting the existing one? to check for Windows, Linux, Mac separately?

PF4Public avatar Jul 01 '22 12:07 PF4Public

The Stable channel has been updated to 103.0.5060.114 for Windows. which will roll out over the coming days/weeks.

:D

PF4Public avatar Jul 04 '22 17:07 PF4Public

There seems to be some important security fixes for actively targeted bugs in that release...

So, how do we move forward on this?

teeminus avatar Jul 05 '22 16:07 teeminus

There is no tarball yet anyway.

PF4Public avatar Jul 05 '22 17:07 PF4Public

There is no tarball yet anyway.

I think all downstream maintainers basically gave up on that getting available

So, how do we move forward on this?

I think we should have patchset releases (and as such a workflow and issues with seperate platform tags) for every version that targets at least one actively maintained platform

networkException avatar Jul 05 '22 17:07 networkException

I think, we've handled it it main repo.

PF4Public avatar Sep 07 '22 15:09 PF4Public