ungoogled-chromium-windows
ungoogled-chromium-windows copied to clipboard
Do you accept pull request on the file build.py?
Today I've tried build with Visual Studio 2022, and it worked after some trial and error. During the process, I modified some building related files, since VS2022 is a 64bit program and the location of some directories changed. Also I found that the file build.py
could be improved drastically. For example, if there are some errors and the execution got interrupted, and you restarted build.py
. You will find that it re-extracts Chromium's source code! And that's more than 600,000 files and the size is more than 8GB, and nothing changed!
I could create a pull request if you would like merge my change to these files.
Yes, please open the pull request
Has Visual Studio 2022 been supported?
built succesfully with https://github.com/teeminus/ungoogled-chromium-windows
built succesfully with https://github.com/teeminus/ungoogled-chromium-windows
How is this version different from the original version on https://github.com/ungoogled-software/ungoogled-chromium-windows?
There is no difference.
@teeminus I am developing on VS 2022, after I run "py package.py" successfully, no .sln files are generated? And I've fixed some code in build\src, I can't run "py build.py" successfully. Did I do anything wrong?
I don’t use VS, so I cannot answer any questions on that topic, sorry. The package.py script is supposed to run after successfully running build.py as it’s used to generate the installer package.
Sorry for being unclear, and it's a shame you're not using VS. I am developing on windows. With the first build I successfully ran build.py and package.py and then I customed some code in build\src. I then ran build.py again with no success, so I couldn't run package.py to spawn a fresh install of my patch. Sorry I'm pretty new to ungoogled-chromium. I read the documentation very carefully and took a week to try it without success. And I just have to ask everyone here.
The build.py script is build to run only once. If there are artifacts left from a previous run, it will fail. Try checking out the chromium build instructions on how to use VS.