ungoogled-chromium-portablelinux icon indicating copy to clipboard operation
ungoogled-chromium-portablelinux copied to clipboard

Consider using sysroot or sysroot scripts inside Docker

Open Eloston opened this issue 5 years ago • 1 comments

Chromium's sysroot scripts have quite a few modifications to maximize compatibility of their builds (see HacksAndPatchesCommon in https://chromium.googlesource.com/chromium/src.git/+/master/build/linux/sysroot_scripts/sysroot-creator.sh). We should include them so we have the same compatibility as official Chrome/Chromium.

There are two ways we could implement this:

  1. Modify the Docker environment with these hacks. We may have to reimplement the hacks ourselves in this case.
  2. Add another build method that creates a sysroot image and configure GN to use it. It should be possible to add this to build.sh, but I don't know how easy that is. It also makes the Docker container a bit redundant.

Eloston avatar Nov 28 '19 22:11 Eloston

Discussion welcome on choosing a solution (or finding another one).

Eloston avatar Nov 28 '19 22:11 Eloston

the sysroot feature is used in the meantime

clickot avatar Dec 11 '23 00:12 clickot