go3d icon indicating copy to clipboard operation
go3d copied to clipboard

Bug in mat4.Quaternion()

Open johannes-graeter opened this issue 8 months ago • 1 comments

Hi, thanks a lot for filling this gap in golang! Lets get to it: I think there is a problem in mat4.Quaternion() A. for calculating the trace only the part of the rotation matrix should be taken (Trace3) not the tracec of the full mat4 B. IMO you need to switch on the sign of the trace to account for ambiguities, right (see f.e. eigen quaternions line 822 following....)

Best Johannes

johannes-graeter avatar Jun 27 '24 15:06 johannes-graeter