SafeMapper icon indicating copy to clipboard operation
SafeMapper copied to clipboard

Nuget package missing new targets

Open AGusty opened this issue 9 years ago • 5 comments

Aspnet 5 needs dnx451 and dnxcore50 targets.

AGusty avatar Jul 23 '15 14:07 AGusty

I have some trouble getting it to work under dnxcore50, but the existing Nuget package works under dnx451. To resolve this in your Aspnet 5 project you can remove dnxcore50, from the frameworks listed in project.json. Hope this helps.

unger avatar Oct 29 '15 14:10 unger

Thanks but my webapp uses .net core. I created a new solution (I can email you) based on your AspNet5PackageLibrary branch. Now all tests pass except those who use SetConvertMethod because Roslyn changed behavior of compiled lambdas (no more static method): http://stackoverflow.com/a/31651531 I think by now you may publish a beta version without SetConvertMethod.

AGusty avatar Dec 18 '15 16:12 AGusty

Great thanks, you can attach the file in a comment here, and I will take a look at it. I am aware of the SetConvertMethod issues with Roslyns changed handling of lambdas. I have made some changes regarding lambda functions in the latest master branch, I think that should fix those problems.

unger avatar Dec 20 '15 22:12 unger

Sorry for delay. But I can't attach, is a zip but it seems that don't support that file type...

AGusty avatar Jan 05 '16 01:01 AGusty

Maybe you can try to make a pull request with the changes, that way it will probably be easier for me to merge the changes.

unger avatar Jan 12 '16 18:01 unger